search

nophead / NopSCADlib

Library of parts modelled in OpenSCAD and a framework for making projects
GNU General Public License v3.0
1.17k stars 155 forks source link

Added photo interrupter module #254

Closed dirkjankrijnders closed 1 year ago

dirkjankrijnders commented 1 year ago

These tend to be popular in robot kits and from china in general.

nophead commented 1 year ago

Thanks. A few problems I noticed:

There are no markup comments for the description, functions and modules, which are needed to generate the correct readme.

It is better to represent black with grey(10) or grey(20) because otherwise all faces are the same colour and it looks 2D.

The cylinders for the holes need to be longer than the base to make them visible but it is better to do the difference in 2D with circles and then linear_extrude the result to avoid that problem.

dirkjankrijnders commented 1 year ago

Hi, Thanks for the feedback, I fixed the things mentioned in your comment. Let me know if there is more to fix!