search

nopnop2002 / Arduino-LoRa-Ra01S

An Arduino Library for LoRa Communication using SX1262/1268
MIT License
29 stars 10 forks source link

Missing license for RadioLib code #2

Closed jgromes closed 2 years ago

jgromes commented 2 years ago

Hello!

I'm the maintainer of the RadioLib project (https://github.com/jgromes/RadioLib), an open-source radio driver library. It seems like you have used a not-insignificant amount of code from that project - for example most of the register definitions in the Ra01S.h header (in RadioLib found in https://github.com/jgromes/RadioLib/blob/master/src/modules/SX126x/SX126x.h), as well as most low-level SPI access commands and SX126x commands (in RadioLib found in https://github.com/jgromes/RadioLib/blob/master/src/modules/SX126x/SX126x.cpp).

RadioLib uses MIT license, which allows to freely reuse any portion of the software for any purpose, however, the original license has to be stated. Therefore, to comply with RadioLib license, I would like to ask you to add the original RadioLib license (found here: https://github.com/jgromes/RadioLib/blob/master/license.txt) to this project.

Thanks!

nopnop2002 commented 2 years ago

Hello

I ported from here. https://github.com/tinytronix/SX126x

jgromes commented 2 years ago

That repository is also using code from RadioLib - in compliance with RadioLib license, as the original text is listed here: https://github.com/tinytronix/SX126x/blob/master/RadioLibLicense.txt

I also raised a similar issue in that repository a couple of years ago: https://github.com/tinytronix/SX126x/issues/2

It doesn't really matter where you got the code - if you're using licensed software, even if it is an open-source license, you still have to comply with it.

nopnop2002 commented 2 years ago

I added this.

https://github.com/nopnop2002/Arduino-LoRa-Ra01S/blob/main/RadioLibLicense.txt

jgromes commented 2 years ago

Thanks, I think that should cover it then.