search

nopnop2002 / esp-idf-ssd1306

SSD1306/SH1106 Driver for esp-idf
MIT License
238 stars 68 forks source link

ESP-IDF component #6

Closed VedantParanjape closed 4 years ago

VedantParanjape commented 4 years ago

Converted to esp-idf component, tested with a app, works

nopnop2002 commented 4 years ago

I updated CMakeLists.txt 4 days ago. Please check the latest version.

VedantParanjape commented 4 years ago

Updating the CmakeLists doesn't make this a component.

nopnop2002 commented 4 years ago

Please explain the benefits of PR once again.

I can't understand the benefits of your PR.

There is no change in your README.md. If you want to make it a component, you also need to change the README.

nopnop2002 commented 4 years ago

If you want to expose it as a component, I suggest the following:

  1. Your repository and my repository exist independently.

  2. Your repository renames esp-idf-ssd1306 to esp-idf-ssd1306-component.

  3. The README for my repository states that your repository is available as a component.

People can choose to use your component or modify my repository. People may prefer your component over my example. But some people might like my example.

Please consider.

VedantParanjape commented 4 years ago

Yup, Seems good. I'll do so.

Regards.