nopnop2002 / esp-idf-st7789

ST7789 Driver for esp-idf
MIT License
234 stars 56 forks source link

Can not auto reset on my board #25

Open chenjr15 opened 2 years ago

chenjr15 commented 2 years ago

The screen cant reset after I flash the code. After I double the delay of reset pin it can auto reset now.

    if ( GPIO_RESET >= 0 ) {
        //gpio_pad_select_gpio( GPIO_RESET );
        gpio_reset_pin( GPIO_RESET );
        gpio_set_direction( GPIO_RESET, GPIO_MODE_OUTPUT );
        gpio_set_level( GPIO_RESET, 1 );
        delayMS(50);
        gpio_set_level( GPIO_RESET, 0 );
        // change from 50
        delayMS(100);
        gpio_set_level( GPIO_RESET, 1 );
        delayMS(50);
    }
nopnop2002 commented 2 years ago

The reset timing may be different for each TFT.

nopnop2002 commented 2 years ago

I think there is an electrical problem around reset circuit in the breakout without the CS pin. Perhaps the reset circuit requires a lot of current. I inserted a 100 ohm resistor between Vcc and RESET.

TroubleShooting

DaveDavenport commented 1 year ago

I find the 100 ohm pull up weird.. Its an active low signal and if I measure the level when not asserted it is 3.3V. On the esp8266 the display works (without external components, with the adafruit library) and in general esp8266 (from what I found) can sink/source less current then the esp32. I wonder if it is more a timing issue.

Secondly, with the 100 Ohm pull up the esp32 needs to sink at least 33mA to pull the signal low (active low to reset), this feels high. The documentation (but it is not very clear) states a max of 28mA.

If I find time I will hook up a scope and see if I can spot a difference so we know for sure.

DaveDavenport commented 1 year ago

The moment I add some debug code to delayMS my display works, if I remove it, it fails.. this suggest a timing issue (is compiler optimizing stuff away?)

DaveDavenport commented 1 year ago

This made it work for me (tm), might be a double thing?

diff --git a/main/st7789.c b/main/st7789.c
index 5bde9bc..da8b62e 100644
--- a/main/st7789.c
+++ b/main/st7789.c
@@ -63,11 +63,11 @@ void spi_master_init(TFT_t * dev, int16_t GPIO_MOSI, int16_t GPIO_SCLK, int16_t
                gpio_reset_pin( GPIO_RESET );
                gpio_set_direction( GPIO_RESET, GPIO_MODE_OUTPUT );
                gpio_set_level( GPIO_RESET, 1 );
-               delayMS(50);
+               delayMS(100);
                gpio_set_level( GPIO_RESET, 0 );
-               delayMS(50);
+               delayMS(200);
                gpio_set_level( GPIO_RESET, 1 );
-               delayMS(50);
+               delayMS(300);
        }

        ESP_LOGI(TAG, "GPIO_BL=%d",GPIO_BL);
@@ -98,7 +98,7 @@ void spi_master_init(TFT_t * dev, int16_t GPIO_MOSI, int16_t GPIO_SCLK, int16_t
        memset(&devcfg, 0, sizeof(devcfg));
        devcfg.clock_speed_hz = SPI_Frequency;
        devcfg.queue_size = 7;
-       devcfg.mode = 2;
+       devcfg.mode = 3;
        devcfg.flags = SPI_DEVICE_NO_DUMMY;

        if ( GPIO_CS >= 0 ) {
@@ -199,11 +199,13 @@ bool spi_master_write_colors(TFT_t * dev, uint16_t * colors, uint16_t size)
        return spi_master_write_byte( dev->_SPIHandle, Byte, size*2);
 }

change spi mode to 3 (hint I found somewhere else) and add a bit more delay.

nopnop2002 commented 1 year ago

I tried your code, But don’t work for me.

After adding the circuit below, it works fine.

ESP32 3V3  -------------------------------+
                                          |
                                          | Emitter
                                         /
                                        /
ESP32 RES  ------------R(2.2K)---------|    S8080
                                Base    \
                                         \
                                          | Collector
                                          |
ST7789 RST -------------------------------+
                                          |
                                          |
                                          |
                                          |
ESP32 GND  ------------R(220)-------------+
DaveDavenport commented 1 year ago

So you are inverting the reset signal? did not expect that as solution. (if V(E-B) is above threshold it conducts, so if res is pulled low, ST7780 RST goes high)

nopnop2002 commented 1 year ago

you are inverting the reset signal?

No.

There was a typo for S8050 instead of S8080

The two circuits below are very similar. In both cases, when the ESP32 RES goes HIGH, the ST7789's RST goes HIGH. The current flowing through the RST of the ST7789 is different. The upper circuit carries more current.

ESP32 3V3  -------------------------------+
                                          |
                                          | Emitter
                                         /
                                        /
ESP32 RES  ------------R(2.2K)---------|    S8050
                                Base    \
                                         \
                                          | Collector
                                          |
ST7789 RST -------------------------------+
                                          |
                                          |
                                          |
                                          |
ESP32 GND  ------------R(220)-------------+

ESP32 RES  -------------------------------+
                                          |
ST7789 RST -------------------------------+
DaveDavenport commented 1 year ago

hmm I assume C/E is swapped, so you are pulling the rst to ~(3.3V-0.7V ) . It is still odd behavior, I will scope it when I have time.

For me the SPI mode 3 (same as was used in the adafruit demo on the esp8266) and slightly longer reset (again picked values from working esp8266 example) works reliable so far. I've done 40 resets and around 15 power cycles and it came back fine every time.

nopnop2002 commented 1 year ago

For me, SPI mode 3 and mode 2 both work fine.

DaveDavenport commented 1 year ago

I'm going to get some more modules (slighlty different form factor) soon, I will report back how they work.

nopnop2002 commented 1 year ago

If you have a scope, I want you to observe the current through RES and the voltage on RES.

DaveDavenport commented 1 year ago

image That signal looks fine. the esp32c3 has no problems asserting that.

nopnop2002 commented 1 year ago

Do you know the current value?

I think that the current value has an effect.

DaveDavenport commented 1 year ago

Given the above trace, I see no reason to measure current. It clearly is not an issue.

(also your above schematic with the 220 ohm resistor to ground shows the current it takes is most likely < 10mA. )

Did a quick measurement, at high, the current going is 0.1mA, less for pulling to ground. so this is clearly a high-z input.

nopnop2002 commented 1 year ago

The schematic was wrong. Sorry for the confusion.

Circuit A works on ESP32. Circuit B don't works on ESP32. Circuit B works on ESP32-S2/ESP32-C3.

circuit A
ESP32 3V3  -------------------------------+
                                          |
                                          | Collector
                                         /
                                        /
ESP32 RES  ------------R(2.2K)---------|    SS8050
                                Base    \
                                         \
                                          | Emitter
                                          |
ST7789 RST -------------------------------+
                                          |
                                          |
                                          |
                                          |
ESP32 GND  ------------R(220)-------------+
circuit B
ESP32 RES  -------------------------------+
                                          |
ST7789 RST -------------------------------+
DaveDavenport commented 1 year ago

Ill retry it with an esp32. Was using an esp32c3 now.

sl45sms commented 7 months ago

Try to use SPI mode 3 for modules with CS grounded. Not any external circuit required.

DaveDavenport commented 7 months ago

Try to use SPI mode 3 for modules with CS grounded. Not any external circuit required.

yes, see my reply above. SPI mode 3 works perfectly reliable. I have ~400 devices now running with the right mode without any issues or any extra reset circuitry.

nopnop2002 commented 7 months ago

I'll test it on the weekend.

nopnop2002 commented 7 months ago

Changed SPI mode from 2 to 3. Test results are good. No pull-up resistor is required on the reset pin.

Thank you. @DaveDavenport @sl45sms

DaveDavenport commented 7 months ago

related https://github.com/nopnop2002/esp-idf-st7789/issues/38

nopnop2002 commented 7 months ago

@DaveDavenport

Thank you.

DaveDavenport commented 7 months ago

Thanks again for your library.