nopnop2002 / esp-idf-st7789

ST7789 Driver for esp-idf
MIT License
234 stars 56 forks source link

Adding support for esp32s3, fixing some compile errors #28

Closed cr1tbit closed 2 years ago

cr1tbit commented 2 years ago

Hey, I'm really grateful for this project, will speed up my work considerably.

Sharing my fixes allowing it to run with ESP32S3.

Best regards, Jakub

NoahMaceri commented 2 years ago

Just wanted to comment and confirm that this update is working on an ESP32s3. Might want to update the Kconfig.projbuild with defaults for the s3 (Will have the change range from 0 to 47). The pins I used to test:

nopnop2002 commented 2 years ago

Thank you for PR.

I ordered the ESP32-S3.

I will refer to your PR.

nopnop2002 commented 2 years ago

Currently, ESP-IDF is in the process of migrating to Ver5.

S3 support and Ver5 support should be considered separately.

These are mixed in your PR.

ESP-IDF Ver5 is very buggy.

The transition to Ver5 is very dangerous.

Therefore, I will support ESP32-S3 with Ver4.4 in the near future.

When ESP-IDF Ver5 becomes stable, we will release the corresponding version again.

cr1tbit commented 2 years ago

All right, I'm not (yet) that deeply into ESP32 development to know such things.

I suggest leaving that PR open until you make those changes, since it helped at least one person so far.

Thanks for looking into my contribution :)

nopnop2002 commented 2 years ago

Unlike esp32-s2, esp32-s3 can use the JPEG library.

$ ls esp-idf/components/esp_rom/include/esp32s3/rom/tjpgd.h
esp-idf/components/esp_rom/include/esp32s3/rom/tjpgd.h
nopnop2002 commented 2 years ago

The changes to Kconfig.projbuild have already been implemented in the latest version.