noppefoxwolf / TwitterVideoUploader

MIT License
3 stars 0 forks source link

Some compile issues on Xcode 9.0.1 #2

Open ghost opened 6 years ago

ghost commented 6 years ago

There are some compile errors on on Xcode 9.0.1 using pod "TwitterVideoUploader", e.g.

# Location: STTwitter+Extensions.swift#STTwitterAPI#APPEND Error: Missing argument for parameter #1 in call for 'observer.onNext()' Fix: observer.onNext(<#Void#>)

# Location: STTwitter+Extensions.swift#STTwitterAPI#STATUS Error: Missing argument for parameter #1 in call for 'observer.onNext()' Fix: observer.onNext(<#Void#>)

# Location: VideoInfo.swift#AVURLAsset#videoTrack Error: 'AVMediaTypeVideo' has been renamed to 'AVMediaType.video' Fix: Replace 'AVMediaTypeVideo' with 'AVMediaType.video'

noppefoxwolf commented 6 years ago

@xiaobingo Please try build with xcode9.1 again.

ghost commented 6 years ago

@noppefoxwolf, thanks for your quick response.

With your latest commits, it works by building cloned projects from this repo. However, the errors still exist using pod "TwitterVideoUploader" from my own project. Has it been updated to CocoaPods? Thx.

ghost commented 6 years ago

to reproduce:

  1. create new xcode 9.01 project
  2. edit Podfile, after edit use_frameworks!

target 'xyz_project' do pod 'TwitterVideoUploader' end

  1. pod install
  2. go to xcode, build project

The aforementioned errors show up. Thanks for you investigation!!!

You did a quite great contribution given non-trivial work of Twitter video upload.

noppefoxwolf commented 6 years ago

Please try to match the following environment.

Xcode 9.1 Swift 4.0 TwitterVideoUploader 0.3.0

You can check with Xcode, swift -v and Podfile.lock.

noppefoxwolf commented 6 years ago

Is there any other Pod that refers to RxSwift? TwitterVideoUploader depends on RxSwift 4.0.

ghost commented 6 years ago

Hi noppefoxwolf,

I resolved this issue by following example project layout, i.e. add TwitterVideoUploader.podspec in my project, and change spec location accordingly. pod 'TwitterVideoUploader', :path => '.' (i.e. pointing to dir where TwitterVideoUploader.podspec is)

Thanks.