search

noppolp / videogular-quality

Quality selection for Videogular
MIT License
7 stars 3 forks source link

Emit an angular event when a new quality is selected #7

Closed GeneralistDev closed 7 years ago

GeneralistDev commented 8 years ago

This change allows developers to listen to quality changes so that they can save the user's quality preference to give a better user experience when they return to the site.

cawabunga commented 7 years ago

Don't it be better to add callback or lifecycle hook? Personally I don't like emitting events on $rootScope.

GeneralistDev commented 7 years ago

Yep, you're right