search

noprompt / ankha

A data inspection component for Om
Eclipse Public License 1.0
132 stars 12 forks source link

Don't let users insert non-associative datastructures #11

Open travis opened 10 years ago

travis commented 10 years ago

Om only supports associative datastructures in its atom - don't let users insert anything that is not associative

noprompt commented 10 years ago

While one of the uses of this library is to provide inspection into the data that drives an Om application that is not the entirety of it's purpose. My vision for Ankha is to have a general purpose inspection tool.

There isn't much value in disallowing people to insert whatever they please. If our intention is to consider this, however, it should be configurable. At the end of the day my faith rests with the users of this library to do the right thing. That is, I make the assumption Ankha's users are intelligent. If they make a bad choice, well, that's on them. Hit the refresh button. No big deal.

travis commented 10 years ago

cool, yeah, I'm in agreement here - @sgrove's original idea was to disallow editing of "uneditable" structures, but I'm not sure that makes sense given the larger goal of ankha: in a general sense any cljs.reader/read-stringable thing should be editable. totally fine closing this issue.