noprompt / garden

Generate CSS with Clojure
1.35k stars 90 forks source link

Fix "0%" being replaced with "0" when pretty-printing is disabled #172

Closed luontola closed 5 years ago

luontola commented 5 years ago

Fixes #120 Fixes #116

The root cause was in the YUI Compressor and required a dirty hack to prevent it from changing "0%" to "0". In the long run it might be preferable to switch to a CSS compressor which is still maintained. YUI Compressor's latest release is from 2013.

luontola commented 5 years ago

This PR has been released as an unofficial build:

[org.clojars.luontola/garden "1.3.6-patch1"]

https://clojars.org/org.clojars.luontola/garden

noprompt commented 5 years ago

Apologies for the delay on merging this. Thanks for fixing the bug. I'm not sure why the test suite needed to be changed in the manner it was but it's not important.

noprompt commented 5 years ago

@luontola I'm going to add you to the list of folks who can contribute directly to the project. In the future, try directly contacting me in Slack if I do not respond in a timely manner.