Fix issue where certain media queries produce invalid css when compression is enabled (cljs)

noprompt / garden

Generate CSS with Clojure

1.34k stars 87 forks source link

Fix issue where certain media queries produce invalid css when compression is enabled (cljs) #173

Closed roosta closed 5 years ago

roosta commented 5 years ago

Tried my hand at a pull request, this fixes #168 by preserving whitespace after and in media queries when compression is enabled (:pretty-print false). Previously the whitespace after and would be slurped up by the :r-paren regexp since some media queries like min-width is parenthesized , leaving us with an invalid media query.

noprompt commented 5 years ago

Sorry for the delay on merging this. I've been busy with other things and I didn't see this pull request.

noprompt commented 5 years ago

@roosta I will add you to the list of collaborators for this project. If in the future, I take a too long to respond to an issue like this, @ message me here on Clojurians Slack.

roosta commented 5 years ago

No worries about the delay, perfectly understandable. I'll be sure to message you if the need arise.