Closed vemv closed 3 years ago
Thanks! I will review this tonight!
Sure!
Btw I was thinking of splitting the JVM clojure build into two: with and without clojurescript in the classpath. That way one makes sure that the conditional inside defmacro val-op
causes no trouble.
Can provide it if that helps
@vemv this looks fine to me. As far as splitting the build, could you give me some more details? I'm not happy with how things are right now but it's working to keep the project free of the ClojureScript dependency. If you know how to make it better, by all means, please do! 😄
Done! Congrats on the Strange Loop chat, will watch
Addresses all reflection warnings by adding type hints, or marking defns that appeared to only target cljs as such
I verified that reflection count decreases to zero with
lein check
.