search

noprompt / meander

Tools for transparent data transformation
MIT License
918 stars 55 forks source link

reflection warning in epsilon util, fixes #230 #237

Closed brandonstubbs closed 1 year ago

brandonstubbs commented 1 year ago

Just wanted to first say thank you for your hard work on this library. I started playing around with it today and it's awesome!

Fixed issue with reflection warning reported in #230. I added bb reader conditionals before the clj ones which prevent us from trying to dynamically load the class. Babashka Reader conditionals will read bb before clj.

I added cache in gitignore which clj-kondo & lsp-lisp use and is safe to ignore. I added calva in gitignore for anyone who codes using calva on VSCode.

Please let me know if you have any questions or you want me to make any changes.

brandonstubbs commented 1 year ago

I just opened another PR #238 - It will be better to get that one in first so that you will be able to see all the tests that run in your ci workflow on the pull request before needing to merge.

Just wanted to add another little useful feature you may enjoy (Especially if you prefer github notification for management) https://joeprevite.com/auto-assign-pull-requests-github. This will allow any new PR's on the repo to be assigned to you so you can be notified.