noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Added a template_schema_url to all IAMbic templates. #534

Closed Will-NOQ closed 1 year ago

Will-NOQ commented 1 year ago

Added a template_schema_url to all IAMbic templates. Handling exceptions_seen as part of the git apply workflow.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 89.65% and project coverage change: -9.73% :warning:

Comparison is base (5fea957) 83.74% compared to head (667eb92) 74.01%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================== - Coverage 83.74% 74.01% -9.73% ========================================== Files 105 105 Lines 12209 12232 +23 ========================================== - Hits 10224 9054 -1170 - Misses 1985 3178 +1193 ``` | Flag | Coverage Δ | | |---|---|---| | functional_tests | `?` | | | functional_tests_config_discovery | `?` | | | unit_tests | `74.01% <89.65%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/plugins/v0\_1\_0/github/github.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2dpdGh1Yi9naXRodWIucHk=) | `63.12% <50.00%> (-0.24%)` | :arrow_down: | | [iambic/config/dynamic\_config.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvbmZpZy9keW5hbWljX2NvbmZpZy5weQ==) | `85.05% <100.00%> (-1.87%)` | :arrow_down: | | [iambic/core/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvbW9kZWxzLnB5) | `84.10% <100.00%> (-5.55%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/iam/group/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vZ3JvdXAvbW9kZWxzLnB5) | `37.68% <100.00%> (-47.00%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/iam/policy/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vcG9saWN5L21vZGVscy5weQ==) | `64.19% <100.00%> (-28.37%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/iam/role/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vcm9sZS9tb2RlbHMucHk=) | `51.00% <100.00%> (-42.47%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/iam/user/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vdXNlci9tb2RlbHMucHk=) | `46.78% <100.00%> (-45.57%)` | :arrow_down: | | [...0\_1\_0/aws/identity\_center/permission\_set/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pZGVudGl0eV9jZW50ZXIvcGVybWlzc2lvbl9zZXQvbW9kZWxzLnB5) | `75.40% <100.00%> (-9.32%)` | :arrow_down: | | [...bic/plugins/v0\_1\_0/aws/organizations/scp/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9vcmdhbml6YXRpb25zL3NjcC9tb2RlbHMucHk=) | `62.45% <100.00%> (-27.63%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/azure\_ad/group/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F6dXJlX2FkL2dyb3VwL21vZGVscy5weQ==) | `82.19% <100.00%> (-7.47%)` | :arrow_down: | | ... and [6 more](https://app.codecov.io/gh/noqdev/iambic/pull/534?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | | ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/534/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.