search

noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
283 stars 26 forks source link

Fix issue when identity center details is lost during 2nd setup #541

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

Without the change, run iambic setup, choose AWS, wait til log mention config sync. Check if identity center value is lost in config?

With the change, run iambic setup, choose AWS, wait til log mention config sync. Check if identity center is lost?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +9.79% :tada:

Comparison is base (9a25e73) 74.13% compared to head (1c54984) 83.92%. Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #541 +/- ## ========================================== + Coverage 74.13% 83.92% +9.79% ========================================== Files 105 105 Lines 12148 12151 +3 ========================================== + Hits 9006 10198 +1192 + Misses 3142 1953 -1189 ``` | Flag | Coverage Δ | | |---|---|---| | functional_tests | `65.91% <33.33%> (?)` | | | functional_tests_config_discovery | `46.03% <100.00%> (?)` | | | unit_tests | `74.14% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/plugins/v0\_1\_0/aws/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9tb2RlbHMucHk=) | `88.86% <100.00%> (+29.42%)` | :arrow_up: | ... and [48 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.