noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Fix EN-2377 Use list instead of set for deterministic iteration order #565

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (cb37e83) 83.77% compared to head (2673faa) 83.76%. Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #565 +/- ## ========================================== - Coverage 83.77% 83.76% -0.01% ========================================== Files 105 105 Lines 12298 12298 ========================================== - Hits 10303 10302 -1 - Misses 1995 1996 +1 ``` | Flag | Coverage Δ | | |---|---|---| | functional_tests | `65.98% <100.00%> (-0.08%)` | :arrow_down: | | functional_tests_config_discovery | `46.09% <100.00%> (ø)` | | | unit_tests | `74.02% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/core/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvbW9kZWxzLnB5) | `89.73% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/565/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.