noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
283 stars 26 forks source link

EN-2379 Turn on CF Stacksets for Organizations when possible #569

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

How to test. Mint a new account, turn on organization. Test the flow. If you really want to test it in an existing org account. u have to use cf client to deactivate organization access. (I am not sure the ramification for existing deployed stacksets tho.)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.11% :warning:

Comparison is base (9939901) 83.91% compared to head (26aeeb6) 83.80%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #569 +/- ## ========================================== - Coverage 83.91% 83.80% -0.11% ========================================== Files 105 105 Lines 12321 12321 ========================================== - Hits 10339 10326 -13 - Misses 1982 1995 +13 ``` | Flag | Coverage Δ | | |---|---|---| | functional_tests | `65.93% <ø> (-0.51%)` | :arrow_down: | | functional_tests_config_discovery | `46.18% <ø> (-0.17%)` | :arrow_down: | | unit_tests | `74.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/569/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.