noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
283 stars 26 forks source link

Fix pre-commit complaints #580

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 55.00% and project coverage change: +9.82% :tada:

Comparison is base (44fadb5) 73.98% compared to head (685d050) 83.81%. Report is 24 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #580 +/- ## ========================================== + Coverage 73.98% 83.81% +9.82% ========================================== Files 105 105 Lines 12361 12361 ========================================== + Hits 9145 10360 +1215 + Misses 3216 2001 -1215 ``` | Flag | Coverage Δ | | |---|---|---| | functional_tests | `65.98% <55.00%> (?)` | | | functional_tests_config_discovery | `46.31% <47.50%> (?)` | | | unit_tests | `73.98% <35.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [...v0\_1\_0/aws/identity\_center/permission\_set/utils.py](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pZGVudGl0eV9jZW50ZXIvcGVybWlzc2lvbl9zZXQvdXRpbHMucHk=) | `90.58% <41.66%> (+7.64%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9tb2RlbHMucHk=) | `88.14% <63.63%> (+29.87%)` | :arrow_up: | | [iambic/output/text.py](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL291dHB1dC90ZXh0LnB5) | `100.00% <100.00%> (ø)` | | | [...0\_1\_0/aws/identity\_center/permission\_set/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pZGVudGl0eV9jZW50ZXIvcGVybWlzc2lvbl9zZXQvbW9kZWxzLnB5) | `84.84% <100.00%> (+9.30%)` | :arrow_up: | | [...ntity\_center/permission\_set/template\_generation.py](https://app.codecov.io/gh/noqdev/iambic/pull/580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pZGVudGl0eV9jZW50ZXIvcGVybWlzc2lvbl9zZXQvdGVtcGxhdGVfZ2VuZXJhdGlvbi5weQ==) | `96.23% <100.00%> (+20.43%)` | :arrow_up: | ... and [46 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/580/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.