noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Fix #581 Relax Target to stay as account id if we cannot look up its account name #583

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

I attach a SCP to a suspended account and see if I can import it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08% :tada:

Comparison is base (685d050) 83.81% compared to head (c8173ea) 83.89%. Report is 23 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ========================================== + Coverage 83.81% 83.89% +0.08% ========================================== Files 105 104 -1 Lines 12361 12382 +21 ========================================== + Hits 10360 10388 +28 + Misses 2001 1994 -7 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/583/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `66.41% <100.00%> (+0.43%)` | :arrow_up: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `46.24% <100.00%> (-0.07%)` | :arrow_down: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `74.03% <0.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [...bic/plugins/v0\_1\_0/aws/organizations/scp/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9vcmdhbml6YXRpb25zL3NjcC9tb2RlbHMucHk=) | `90.58% <100.00%> (+0.07%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/583/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.