noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
281 stars 26 forks source link

Fix #587 when describe_user and describe_group fail to lookup PrincipalID #588

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

I have to inject exceptions into list_users, list_groups and further error injection into describe_user and describe group. in parallel, I will try to get a AD + IdentityCenter setup.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 18.64% and project coverage change: -0.12% :warning:

Comparison is base (1646ea5) 83.90% compared to head (af2ff38) 83.79%. Report is 34 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ========================================== - Coverage 83.90% 83.79% -0.12% ========================================== Files 104 104 Lines 12381 12389 +8 ========================================== - Hits 10388 10381 -7 - Misses 1993 2008 +15 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `65.99% <10.16%> (-0.40%)` | :arrow_down: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `46.20% <5.08%> (-0.04%)` | :arrow_down: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `74.00% <13.55%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [...v0\_1\_0/aws/identity\_center/permission\_set/utils.py](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pZGVudGl0eV9jZW50ZXIvcGVybWlzc2lvbl9zZXQvdXRpbHMucHk=) | `87.64% <0.00%> (-3.83%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/github/github.py](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2dpdGh1Yi9naXRodWIucHk=) | `63.20% <ø> (ø)` | | | [iambic/plugins/v0\_1\_0/github/github\_app.py](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2dpdGh1Yi9naXRodWJfYXBwLnB5) | `45.75% <16.12%> (ø)` | | | [iambic/plugins/v0\_1\_0/github/create\_github\_app.py](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2dpdGh1Yi9jcmVhdGVfZ2l0aHViX2FwcC5weQ==) | `30.58% <20.00%> (ø)` | | | [...bic/plugins/v0\_1\_0/aws/organizations/scp/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9vcmdhbml6YXRpb25zL3NjcC9tb2RlbHMucHk=) | `90.58% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/588/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.