noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Fix error handling for detect not able to create gist #595

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

I deny the GitHub app to push into gist via branch protection and make sure it can still update the template.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +9.67% :tada:

Comparison is base (c8c7e93) 73.34% compared to head (e8796ec) 83.01%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #595 +/- ## ========================================== + Coverage 73.34% 83.01% +9.67% ========================================== Files 105 105 Lines 12544 12549 +5 ========================================== + Hits 9200 10418 +1218 + Misses 3344 2131 -1213 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/595/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `65.34% <0.00%> (?)` | | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `45.87% <0.00%> (?)` | | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `73.31% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/plugins/v0\_1\_0/github/github.py](https://app.codecov.io/gh/noqdev/iambic/pull/595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2dpdGh1Yi9naXRodWIucHk=) | `61.14% <0.00%> (-0.57%)` | :arrow_down: | ... and [50 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.