noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
281 stars 26 forks source link

Fixed EN-2401 Check parent directory truthy-ness before attempt to create it #603

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e3f5f0c) 83.01% compared to head (5d1162c) 83.02%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #603 +/- ## ======================================= Coverage 83.01% 83.02% ======================================= Files 105 105 Lines 12549 12552 +3 ======================================= + Hits 10418 10421 +3 Misses 2131 2131 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/603/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `65.46% <60.00%> (-0.08%)` | :arrow_down: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `45.81% <100.00%> (+0.02%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `73.31% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/config/dynamic\_config.py](https://app.codecov.io/gh/noqdev/iambic/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvbmZpZy9keW5hbWljX2NvbmZpZy5weQ==) | `87.16% <100.00%> (+0.04%)` | :arrow_up: | | [iambic/core/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvbW9kZWxzLnB5) | `91.10% <100.00%> (+0.04%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/603/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.