noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Fixed #608 Implement import filtering protocol for SCP #609

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

Use the suggested filtering config,

aws:
  import_rules:
      - action: ignore
        match_template_types:
          - NOQ::AWS::IAM::Group
          - NOQ::AWS::IAM::ManagedPolicy
          - NOQ::AWS::IAM::Role
          - NOQ::AWS::IAM::User
          - NOQ::AWS::Organizations::SCP

make sure the iambic-test-org won't have SCP generate as a result of import.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -9.83% :warning:

Comparison is base (c582543) 83.06% compared to head (b76d545) 73.23%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #609 +/- ## ========================================== - Coverage 83.06% 73.23% -9.83% ========================================== Files 105 105 Lines 12580 12587 +7 ========================================== - Hits 10449 9218 -1231 - Misses 2131 3369 +1238 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/609/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `?` | | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `?` | | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `73.23% <50.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [...0\_1\_0/aws/organizations/scp/template\_generation.py](https://app.codecov.io/gh/noqdev/iambic/pull/609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9vcmdhbml6YXRpb25zL3NjcC90ZW1wbGF0ZV9nZW5lcmF0aW9uLnB5) | `91.96% <50.00%> (-3.28%)` | :arrow_down: | ... and [50 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/609/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.