noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Inline jsonschema2md to handle format #621

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (2ad6fa9) 82.94% compared to head (c75b6b3) 82.97%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #621 +/- ## ========================================== + Coverage 82.94% 82.97% +0.03% ========================================== Files 105 105 Lines 12588 12588 ========================================== + Hits 10441 10445 +4 + Misses 2147 2143 -4 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/621/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `66.05% <ø> (+0.13%)` | :arrow_up: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `45.78% <ø> (ø)` | | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `73.22% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smoy commented 1 year ago

I open up upstream change as well, but since its a single developer, not sure how often PR are reviewed: https://github.com/sbrunner/jsonschema2md/pull/128