noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
285 stars 26 forks source link

Add stable sorting for credentials and access keys #629

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 73.23% and project coverage change: -0.17% :warning:

Comparison is base (dfcd725) 82.95% compared to head (2674d7c) 82.79%. Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #629 +/- ## ========================================== - Coverage 82.95% 82.79% -0.17% ========================================== Files 105 105 Lines 12588 12781 +193 ========================================== + Hits 10443 10582 +139 - Misses 2145 2199 +54 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/629/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `66.05% <71.21%> (+0.10%)` | :arrow_up: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `46.03% <50.00%> (+0.08%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `72.76% <43.93%> (-0.47%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/core/template\_generation.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvdGVtcGxhdGVfZ2VuZXJhdGlvbi5weQ==) | `91.94% <ø> (ø)` | | | [iambic/core/git.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvZ2l0LnB5) | `78.97% <50.00%> (-0.68%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/iam/user/utils.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vdXNlci91dGlscy5weQ==) | `78.49% <58.87%> (-10.45%)` | :arrow_down: | | [iambic/plugins/v0\_1\_0/aws/handlers.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9oYW5kbGVycy5weQ==) | `54.24% <100.00%> (+0.11%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/iam/user/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vdXNlci9tb2RlbHMucHk=) | `94.03% <100.00%> (+1.63%)` | :arrow_up: | | [...plugins/v0\_1\_0/aws/iam/user/template\_generation.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vdXNlci90ZW1wbGF0ZV9nZW5lcmF0aW9uLnB5) | `95.29% <100.00%> (+0.29%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/iambic\_plugin.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW1iaWNfcGx1Z2luLnB5) | `84.44% <100.00%> (+0.17%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/629?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9tb2RlbHMucHk=) | `86.15% <100.00%> (+0.54%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/629/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.