noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
281 stars 26 forks source link

Schema model improvement for Tag #630

Closed smoy closed 1 year ago

smoy commented 1 year ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

This is the experience if someone made a template validation error: https://github.com/noqdev/iambic-templates-itest/pull/333#issuecomment-1703506031

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% :tada:

Comparison is base (2674d7c) 82.79% compared to head (3d5f461) 82.87%. Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #630 +/- ## ========================================== + Coverage 82.79% 82.87% +0.07% ========================================== Files 105 105 Lines 12781 12815 +34 ========================================== + Hits 10582 10620 +38 + Misses 2199 2195 -4 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `66.10% <77.14%> (+0.05%)` | :arrow_up: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `46.15% <77.14%> (+0.12%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `72.83% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [iambic/plugins/v0\_1\_0/aws/iam/policy/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vcG9saWN5L21vZGVscy5weQ==) | `92.91% <ø> (+2.36%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/iam/role/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vcm9sZS9tb2RlbHMucHk=) | `93.06% <ø> (ø)` | | | [iambic/plugins/v0\_1\_0/aws/iam/user/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9pYW0vdXNlci9tb2RlbHMucHk=) | `94.03% <ø> (ø)` | | | [iambic/core/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvbW9kZWxzLnB5) | `91.18% <100.00%> (+0.08%)` | :arrow_up: | | [iambic/core/parser.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL2NvcmUvcGFyc2VyLnB5) | `85.10% <100.00%> (+0.16%)` | :arrow_up: | | [iambic/plugins/v0\_1\_0/aws/models.py](https://app.codecov.io/gh/noqdev/iambic/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#diff-aWFtYmljL3BsdWdpbnMvdjBfMV8wL2F3cy9tb2RlbHMucHk=) | `87.05% <100.00%> (+0.89%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/630/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.