noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
279 stars 26 forks source link

Iambic Detect Fails AWS #631

Closed Wilhite-r closed 11 months ago

Wilhite-r commented 11 months ago

Describe the bug Iambic detect fails on AWS because user group information is stored in a list as opposed to a dict.

To Reproduce Steps to reproduce the behavior:

  1. Go to AWS console
  2. Perform IAM updates
  3. Run Iambic Detect
  4. See error

Expected behavior A list of expected import changes is written to a file

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Community Engagement Your vote counts! Please support this bug report by adding a 👍 reaction to the original issue, which will aid the community and maintainers in addressing this problem.

Please refrain from adding "+1" or "me too" comments, as these create unnecessary noise for issue followers and do not help in prioritizing the issue. If you wish to contribute to solving this issue or have submitted a pull request, please leave a comment.

Wilhite-r commented 11 months ago

Opened a PR for this already: https://github.com/noqdev/iambic/pull/632

smoy commented 11 months ago

the iambic-core 0.11.86 includes the PR fix from #632

thank you for the contribution: https://pypi.org/project/iambic-core/#history