noqdev / iambic

IAMbic is Version-Control for IAM. It centralizes and simplifies cloud access and permissions. It maintains an eventually consistent, human-readable, bi-directional representation of IAM in Git.
https://iambic.org
Apache License 2.0
279 stars 26 forks source link

Better prompt for Google Service Account #635

Closed smoy closed 11 months ago

smoy commented 11 months ago

What changed?

Rationale

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

Screenshot 2023-09-08 at 10 22 47 AM
codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (049fb00) 82.80% compared to head (c0fc7c0) 82.80%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #635 +/- ## ======================================= Coverage 82.80% 82.80% ======================================= Files 105 105 Lines 12815 12815 ======================================= Hits 10612 10612 Misses 2203 2203 ``` | [Flag](https://app.codecov.io/gh/noqdev/iambic/pull/635/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | Coverage Δ | | |---|---|---| | [functional_tests](https://app.codecov.io/gh/noqdev/iambic/pull/635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `64.17% <ø> (-0.18%)` | :arrow_down: | | [functional_tests_config_discovery](https://app.codecov.io/gh/noqdev/iambic/pull/635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `45.34% <ø> (+0.16%)` | :arrow_up: | | [unit_tests](https://app.codecov.io/gh/noqdev/iambic/pull/635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev) | `72.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/noqdev/iambic/pull/635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=noqdev)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.