search

noraj / OSCP-Exam-Report-Template-Markdown

:orange_book: Markdown Templates for Offensive Security OSCP, OSWE, OSCE, OSEE, OSWP exam report
https://noraj.github.io/OSCP-Exam-Report-Template-Markdown/
MIT License
3.53k stars 744 forks source link

Add support for filepaths with spaces #49

Closed h4ckninja closed 8 months ago

h4ckninja commented 11 months ago

Hopefully pretty straight-forward. Worked for me. I had filepaths with spaces, and this fixed it.

noraj commented 11 months ago

I'll take a look into that tomorrow.

noraj commented 8 months ago

Sorry for the delay, when I first saw this I hit Mark as unread but it wasn't taken into account.

Thanks for the suggestion, I introduced the change like this: https://github.com/noraj/OSCP-Exam-Report-Template-Markdown/commit/72cb71796db66f84e87c14f0351237d161059097. The philosophy was to escape only for external command execution only (when it involves a shell). Rather than escaping for all and unescaping when there is no shell involved.