search

norbert-walter / esp32-nmea2000-obp60

nmea2000 gateway with ESP32
GNU General Public License v2.0
14 stars 10 forks source link

duplicate code lib/ob60task vs. lib/queue/obp60task #98

Open speters opened 5 days ago

speters commented 5 days ago

There is duplicate/leftover code. diff -uwr lib/ob60task lib/queue/obp60task

norbert-walter commented 1 day ago

Please make a issue hare: https://github.com/wellenvogel/esp32-nmea2000 I'm d'ont maintain this code.

thooge commented 1 day ago

I do not find the code in https://github.com/wellenvogel/esp32-nmea2000 Only https://github.com/norbert-walter/esp32-nmea2000-obp60/ seems to contain it. I locally deleted it and compield afterwards with no issues. I assume the directory was accidentally created.

norbert-walter commented 8 hours ago

The code for OBP60 is based on wellenvogel's code. The changes in my project are not synchronized with the wellenvogel project. Therefore, the pull requests are only applied to my code. The idea behind this is that we keep the wellenvogel code clean and no user tasks appear there. The extensions to OBP60 can all be found in the /lib/obp60task folder. Code changes that I make only affect this folder. I am not allowed to make any changes outside of the folder, otherwise synchronization with the wellenvogel project is no longer possible. Pull requests from my project to wellenvogel are excluded, otherwise my /lib/obp60task directory would be created there.

This means that I can only correct errors that affect my code in the /lib/obp60task directory. All other changes outside of the directory must be made in the Wellenvogel project.

thooge commented 7 hours ago

You yourself committed the files: see commit f611cab14b8737b40a5aaa7e1ad30322021459ad

norbert-walter commented 5 hours ago

lib/queue is not a part of OBP60 firmware but the includes code is the same as me. I'm not sure what is the idea from Andreas that build this directory. I think it is a backup copy. lib/queue is a part of NMEA2000-Gateway firmware. Please inform Andreas.

norbert-walter commented 5 hours ago

Refer my comments on Segeln-Forum: https://www.segeln-forum.de/thread/73307-multifunktionsdisplay-diy/?postID=2700042#post2700042