search

norberteder / trello

Use the Trello API from Node
332 stars 250 forks source link

Add extra params support everywhere #74

Open karlvr opened 5 years ago

karlvr commented 5 years ago

Addresses #39.

This PR adds the option to adding extra query params to every method without damaging backwards compatibility, by adding an optional extraParams argument to every method call (except those that already have one).

The tests have not been modified, and all pass. I will add tests for the new style too.

karlvr commented 5 years ago

The CI failure looks like it might be a Restler failure with Node 4.

It's on this line:

parsers.xml.options = (typeof options.xml2js == 'undefined') ? {} : options.xml2js;

as parsers.xml is undefined due to a failure to initialise it at the beginning of the tests:

ReferenceError: Invalid left-hand side in assignment

I don't know why it happens on that one test though ¯_(ツ)_/¯