Idan s refactoring popup.js and some improvements

norbit8 / MoodleBooster

Firefox & Chrome addon that boosts moodle's UI/UX.

MIT License

1 stars 13 forks source link

Idan s refactoring popup.js and some improvements #120

Closed idan2468 closed 3 years ago

idan2468 commented 3 years ago

Refactor the popup.js
Resolved the issue of running scripts file with browser.tabs.executeScript so now it's running without the minified text: browser.tabs.executeScript({file: '/content_scripts/courseRemover.js'}).catch(reportError) see issue #121 for details
Changed extension popup behavior see issue #122 for more details

idan2468 commented 3 years ago

Seems like you've mixed some of the PR's changes from #116 to here. Also, are you sure this solution works for chrome?

Yeah it's possible, and yes I've checked it on both. You can see the image I've added explains that you need to put the absolute path (linux style)

norbit8 commented 3 years ago

Seems like you've mixed some of the PR's changes from #116 to here. Also, are you sure this solution works for chrome?

Yeah it's possible, and yes I've checked it on both. You can see the image I've added explains that you need to put the absolute path (linux style)

Alright, so just remove the redundant files and this PR will be approved 💯