norbit8 / MoodleBooster

Firefox & Chrome addon that boosts moodle's UI/UX.

MIT License

1 stars 13 forks source link

[FIX] Yoav removed bootstrap and fixed course remover x #134

Closed norbit8 closed 3 years ago

norbit8 commented 3 years ago

Fixed the following issues:

133

57

Main changes:

Removed the usage of Bootstrap entirely from our project.
Style changes in the course remover option.

New Look without dark-mode:

New Look in dark-mode:

idan2468 commented 3 years ago

Have you seen how it look like with dark mode and enhance page after removing bootstrap? @norbit8

Also could you post pic of how the X button looks like now? And if working well with the dark mode?

norbit8 commented 3 years ago

Have you seen how it look like with dark mode and enhance page after removing bootstrap? @norbit8

Also could you post pic of how the X button looks like now? And if working well with the dark mode?

Updated the first comment, I think it looks legit 😃

idan2468 commented 3 years ago

Have you seen how it look like with dark mode and enhance page after removing bootstrap? @norbit8

Also could you post pic of how the X button looks like now? And if working well with the dark mode?

Updated the first comment, I think it looks legit 😃

I like the red color. I have 2 improvements that I think could be good if it's possible:

Could you add some hover effect to the X button?
Is it possible to put the X with the course link at the same "line" (now the X is a little bit upper than the link) Maybe we could put the x button after the link and it will look better?

If it could be done rapidly I think it worth it. If no we can put issues for some enhancements for future tasks

What do you think?

norbit8 commented 3 years ago

Have you seen how it look like with dark mode and enhance page after removing bootstrap? @norbit8 Also could you post pic of how the X button looks like now? And if working well with the dark mode?

Updated the first comment, I think it looks legit 😃

I like the red color. I have 2 improvements that I think could be good if it's possible:

Could you add some hover effect to the X button?

Is it possible to put the X with the course link at the same "line" (now the X is a little bit upper than the link) Maybe we could put the x button after the link and it will look better?

If it could be done rapidly I think it worth it. If no we can put issues for some enhancements for future tasks

What do you think?

Pushed a new version, I've added the on-over effect. Changing the x to be inline is a bit more complex for me 😆 . (See the new results on the first PR comment)

idan2468 commented 3 years ago

Have you seen how it look like with dark mode and enhance page after removing bootstrap? @norbit8 Also could you post pic of how the X button looks like now? And if working well with the dark mode?

Updated the first comment, I think it looks legit 😃

I like the red color. I have 2 improvements that I think could be good if it's possible:

Could you add some hover effect to the X button?

Is it possible to put the X with the course link at the same "line" (now the X is a little bit upper than the link) Maybe we could put the x button after the link and it will look better?

If it could be done rapidly I think it worth it. If no we can put issues for some enhancements for future tasks

What do you think?

Pushed a new version, I've added the on-over effect. Changing the x to be inline is a bit more complex for me 😆 . (See the new results on the first PR comment)

Great tnx