search

norbit8 / MoodleBooster

Firefox & Chrome addon that boosts moodle's UI/UX.
MIT License
1 stars 13 forks source link

Adding better view of cs grades #150

Closed liron58 closed 3 years ago

liron58 commented 3 years ago

Added support for better view of the cs grades.

currently :

Now you can only see the grades in a small side menu : image in this menu the remarks about the grade are not written and you should click on the grade to see the remarks.

Whats new:

Added a new button : image This button showing the grades with the remakrs in a nice and clear way.

For this dev I have added a spinner support for the dashboard. The new feature looks like this : image and the spinner like this : image

127

idan2468 commented 3 years ago

Why is the dark-mode css deleted?

Beside that what about using the scrape method?
If you put your content script after storageLoader in the content scripts list in the manifest, you should be able to use it there

liron58 commented 3 years ago

Why is the dark-mode css deleted?

Beside that what about using the scrape method? If you put your content script after storageLoader in the content scripts list in the manifest, you should be able to use it there

Dark mode is not required as a change and therefore deleted. When using the storageLoader I got CORS erros , so I decided to duplicate those 3 -4 lines of code.

idan2468 commented 3 years ago

Why is the dark-mode css deleted?

Beside that what about using the scrape method? If you put your content script after storageLoader in the content scripts list in the manifest, you should be able to use it there

Dark mode is not required as a change and therefore deleted. When using the storageLoader I got CORS erros , so I decided to duplicate those 3 -4 lines of code.

So the dark-mode should remain unchanged and not deleted It doesn't suppose to be on the PR changed files. Regarding storageLoader for now leave it as is…

idan2468 commented 3 years ago

Until Liron decides to fix it I'm closing the PR