search

norbusan / kobo-ja-dict-enhance

Enhance built-in Japanese dictionaries from Kobo with English definitions
GNU General Public License v3.0
427 stars 2 forks source link

Fix encoding issue and 7zip issue #1

Closed kvwoerden closed 5 years ago

kvwoerden commented 5 years ago

Fix for the encoding issue that give errors while reading the edict2 file: screen shot 2019-02-05 at 20 29 01 and the issue that makes the script hang because 7zip expects input: screen shot 2019-02-05 at 20 30 05 After these fixes the script works as intended: screen shot 2019-02-05 at 20 31 32

norbusan commented 5 years ago

Thanks for the pull request, looks reasonable. My only question is about the encoding of the edict files. Are they alwasy in euc-jp?

kvwoerden commented 5 years ago

Thank you for creating this program, I enjoy having a Japanese-English dictionary on my Kobo. According to the Format section of http://www.edrdg.org, edict files are distributed in euc-jp.

norbusan commented 5 years ago

Thanks for your patch and comment, merged!