Switch from using Cwd to File::Spec for finding file paths

norbusan / kobo-ja-dict-enhance

Enhance built-in Japanese dictionaries from Kobo with English definitions

GNU General Public License v3.0

427 stars 2 forks source link

Switch from using Cwd to File::Spec for finding file paths #2

Closed rtiangha closed 4 years ago

rtiangha commented 4 years ago

Using Cwd in Cygwin on Windows to find file paths is inconsistent and can fail silently. Switch to using File::Spec instead, which works more reliably and still works across different operating systems.

norbusan commented 4 years ago

Thanks for the patch, that is a good idea. But please, can you remove the edict2 update part? I prefer to have things separate.

Please send a separate PR for the edict2 update.

Thanks a lot!

norbusan commented 4 years ago

??? Why ... just force push removing the edict part :-)

rtiangha commented 4 years ago

Sorry; what I should have done was create a separate branch for just the one change; that's best practice and keeps things cleaner, but I've gotten used to submitting bulk changes in the other projects I contribute to. Sorry for the confusion. Love the script!

norbusan commented 4 years ago

No problem ;-) And sorry for being picky, but it helps cherry-picking commits across branches, if need arises.