search

nordhagen / instagram-tagscrape

NPM module for loading images from Instagram by hashtag without API access by means of scraping.
4 stars 8 forks source link

Update to scrapePostPage #2

Closed evolross closed 7 years ago

evolross commented 7 years ago

Updated returned JSON data reference in scrapePostPage to latest JSON model returned on the post page from IG. This makes scrapePostPage and deepScrapeTagPage work correctly as of the time of this update.

evolross commented 7 years ago

I think the checks are failing because the example fixtures/JSON data is out of date. I didn't update that. I will do that when I get a chance.

nordhagen commented 7 years ago

Weird. The tests were failing so I updated them and then they passed. Now they're failing again. This is what you get when scraping I guess. Will look into it.

evolross commented 7 years ago

The current code is still working for me... I'll paste in the latest fixtures tomorrow on my fork and see if the tests pass.

evolross commented 6 years ago

I finally got around to updating the fixtures. Just the fixtures/postPage.html actually. The tests all passed in my fork after this update. So the post page fixture just needed updating to match the live IG site.

It looks like in your master the fixtures had not been updated (which you mention above on Aug 24 that you did - I'm assuming you meant you updated your text fixtures).

It's updated now. I've created a PR for you and the tests pass.