search

nordic-rse / nordic-rse.github.io

The community of Research Software Engineers in Nordic countries.
https://nordic-rse.org
MIT License
13 stars 15 forks source link

added icons to purple box #316

Closed lucaferranti closed 2 years ago

lucaferranti commented 2 years ago

image

samumantha commented 2 years ago

Small thing: How about having the icons same size as the text or above the text?

samumantha commented 2 years ago

Otherwise looks great <3

lucaferranti commented 2 years ago

I think the icons match the text size at the moment?

Putting them above the text might require a little more tweaking with paddings and sizes to make it nice and responsive, but it's definitely doable, I can give it a try later today.

samumantha commented 2 years ago

Hmm in the picture it looks to me like they are a tiny bit taller (visible mostly at success stories), but might also be such a small detail that does not really matter to people. Maybe I am looking at it wrong 🤔

bast commented 2 years ago

I will merge and then we can adjust still. It's definitely an improvement.