add preview on pr

[github-actions[bot]]

Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/nordic-rse.github.io/previews/PR445/

[lucaferranti]

seems to mainly work (https://github.com/nordic-rse/nordic-rse.github.io/tree/gh-pages/previews/PR445), but does it mess-up the CNAME, since the preview link redirects to nordic-rse.github.io? :thinking:

Maybe the CNAME step should also be run only on main?

cc @rkdarst @bast

[bast]

Maybe the CNAME step should also be run only on main?

Good idea.

[lucaferranti]

closing and reopening to also test the cleanup while updating CNAME

[github-actions[bot]]

Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/nordic-rse.github.io/previews/PR445/

[lucaferranti]

it seems it still redirects to the main website?

[bast]

My feeling is we will need to rename nordic-rse.github.io to something else.

[bast]

To demonstrate my point:

• https://nordic-rse.github.io/nordic-rse.github.io/whatever (this is github)
• https://nordic-rse.github.io/whatever (this is zola)

[lucaferranti]

oh I didn't notice the double nordic-rse.github.io in the link!

Wouldn't it be easier to change the comment_pr action to post a correct link

https://nordic-rse.github.io/previews/PR445/

(this works, note the title "Nordic-RSE in a shell" instead of "Nordic-RSE in a nutshell"

[lucaferranti]

closing and reopening for testing

[github-actions[bot]]

Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/previews/PR445/

[bast]

Nice!

[lucaferranti]

@bast @rkdarst this should be working and ready for review

[lucaferranti]

btw @bast @rkdarst this is ready

[bast]

I am sorry I was under the now with notifications and missed this. This is an awesome feature.