search

nordic-rse / nordic-rse.github.io

The community of Research Software Engineers in Nordic countries.
https://nordic-rse.org
MIT License
13 stars 15 forks source link

In the community map, allow lists of places for groups (and individuals) #455

Closed rantahar closed 4 months ago

github-actions[bot] commented 4 months ago

Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/previews/PR455/

rantahar commented 4 months ago

This draws each institute in all places listed (and same for individuals, if they list multiple places). The downside is that it adds multiple pins where no individual RSE is marked close by.

rantahar commented 4 months ago

The preview does not seem to work. I think it still loads the javascript from the main version.

lucaferranti commented 4 months ago

You need to tweak manually the link of the preview when you look at something which is not the homepage, see this issue: https://github.com/nordic-rse/nordic-rse.github.io/issues/453.

Correct link should be: https://nordic-rse.org/previews/PR455/communities/map/

rantahar commented 4 months ago

@lucaferranti, that still loads the wrong javascript.

rantahar commented 4 months ago

Made a quick fix in the map data by using only one location. This is easy to revert

lucaferranti commented 4 months ago

yeah, I noticed that. Not sure why :thinking:

lucaferranti commented 4 months ago

I think if you ran that locally and works locally, we can assume it's just github setup and merge this

rantahar commented 4 months ago

It works, but I'm not sure we want to do this. It's more a suggested fix.