Only close the session if auto created.

nordicopen / pyeasee

Easee EV charger API python library

MIT License

39 stars 11 forks source link

Only close the session if auto created. #1

Closed Hellowlol closed 4 years ago

Hellowlol commented 4 years ago

Easee.close should only close the connection is the session was not passed manually. (Ill send a PR for this later)

fondberg commented 4 years ago

Right. But why call close then? Maybe the api is not clear

Hellowlol commented 4 years ago

.close should be using to clean up regarding the library. A example: the user passes a shared session and closing this could have unforeseen consequences.

fondberg commented 4 years ago

Fixed in v0.7.9