search

nordicopen / pyeasee

Easee EV charger API python library
MIT License
39 stars 11 forks source link

Update status codes and #28

Closed Hellowlol closed 3 years ago

Hellowlol commented 3 years ago

add status with the status string, raw access to chargerOpmode is now possible.

This will be a breaking change but i think the status codes are better, especially with the updated reason for no current as you get more info about that is happening.

I also wanted to not overwrite the chargerOpmode so this is still a int and status is the string.

fondberg commented 3 years ago

I think it looks good! Do you want to join us in the discord channel where we have a lot of activity? We are 4 main devs atm but are always looking for more

Hellowlol commented 3 years ago

Sure

fondberg commented 3 years ago

Here the channel https://discord.gg/3e6zxR

fondberg commented 3 years ago

Lets make them lowercase and then merge this and right after create a PR to easee_hass which bumps the major version and shows it is a breaking change.

astrandb commented 3 years ago

I haven't been diving into details in the code here so perhaps it is already taken care of, but please make sure that new, unknown integer codes are handled properly, e.g. mapped to "unknownstatus##".