nordicsmartgovernment / requirements

Issue tracking repository
0 stars 0 forks source link

[USER STORY] Update business transaction data (credit note) #20

Open data-david opened 4 years ago

data-david commented 4 years ago

As: a system user (another system used in the PoCs) I wish: to update the existing business transaction details So that: the system can have most complete set of data that is available about the transaction

Relatert til epos: Informasjonsforvaltning/behov_NSG#19

Link to design: Link to solution architecture: https://informasjonsforvaltning.github.io/SA_NordicSmartGovernment/54e87e47-f01c-49fe-af55-2068f4564bd2/views/c095ad5e-c8cc-4638-b977-c7028c8b5d23.html

Business value (Critical/Important/Less important/Nice to have): Important

data-david commented 4 years ago

This story includes validating that data that shall not be changed cannot.

data-david commented 4 years ago

Scenario 1: A vendor have discovered that the original invoice had mistakes (or the Company discovered that it contained mistakes and contacted the vendor). The vendor then sends a new invoice with the negative number (in Norway called a Credit Note) and a correct invoice. Both this is sent to the Company.

The Norwegian accounting act states "it is not allowed to change invoices after they have been made. To change or "delete" an invoice, you must create a credit note that "zeroes out" the original invoice.»

The system also accepts the three invoices (the original, the credit note, and the updated), only the updated will be paid. Also all vouchers are added, three transactions are created. And a number of Entries are also created. Apparently the three transactions are NOT connected by some common attribute? Or are the paymentID (KID in Norway) the same?

All invoices (normal or credit note) are separate vouchers and will be handled as such. That being said at least 2 accounting entries from each voucher is always created. As the credit note is negative in its values, the accounting entries amounts created from it shall also have the opposite signs compared to the original one and they will zero out the original one or correct the amount that was wrong. If the customer had already paid the invoice and it was too big amount, the seller must return that money.

The credit note invoice should reference the original invoice (in UBL/PEPPOL: /Invoice/cac:BillingReference/cac:InvoiceDocumentReference/cbc:ID).

ekoskent commented 4 years ago

I think the case of credit note is not a case for using the update business transaction as the credit note is handled like any other invoice. We could however test the reference implementation with some credit notes to see that the "zeroing out" is happening as expected.