Closed saschametz closed 1 year ago
Hello, I've noticed that several type hints are incorrect. For reference, I checked the official API schema. Below are some examples:
https://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L22-L30
enduser_id
https://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L40-L50
agreements
agreement
link
ssn
account_selection
redirect_immediate
results
@victory-sokolov Hi Viktor, do you to know if there's a plan to make sure the types match up with the API schema?
Maybe pydantic could be of use here?
Hello, I've noticed that several type hints are incorrect. For reference, I checked the official API schema. Below are some examples:
https://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L22-L30
enduser_id
is not available in the API response Ref to API Schemahttps://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L40-L50
agreements
isn't available in the API response, but insteadagreement
(string instead of list) is availableenduser_id
is not available in the API responselink
property is missing in type hintsssn
property is missing in type hintsaccount_selection
property is missing in type hintsredirect_immediate
property is missing in type hintsresults
isn't part of that object Ref to API Schema