nordigen / nordigen-python

Python library for the Nordigen API.
MIT License
56 stars 18 forks source link

Type hints are incorrect according to the API schema #17

Closed saschametz closed 1 year ago

saschametz commented 1 year ago

Hello, I've noticed that several type hints are incorrect. For reference, I checked the official API schema. Below are some examples:


https://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L22-L30


https://github.com/nordigen/nordigen-python/blob/c8b91669a63b4cd12df8e0ba72d47f8df822286e/nordigen/types/types.py#L40-L50

saschametz commented 1 year ago

@victory-sokolov Hi Viktor, do you to know if there's a plan to make sure the types match up with the API schema?

hmol commented 1 year ago

Maybe pydantic could be of use here?