search

nordnet / cordova-hot-code-push-cli

[DEPRECATED] - This is a command line utility for Cordova Hot Code Push Plugin.
https://github.com/nordnet/cordova-hot-code-push-cli/issues/79
143 stars 139 forks source link

Questions about deploying on S3 #39

Closed guv3n closed 5 years ago

guv3n commented 8 years ago

Correct me if I'm wrong but I understand that the files in the S3 bucket are visible to anyone, do you plan on adding a way to set credentials for the app to get the files ?

Not relevant, but when running cordova-hcp init, why do you need the ios_identifier and android_identifier ?

BTW, you made a great work with cordova-hcp and this CLI !

nikDemyankov commented 8 years ago

Thanks. Although, I wasn't the one who developed the CLI client in the beginning. And there was a lot of PR from community, which is great. Just need to get my hands on it.

Correct me if I'm wrong but I understand that the files in the S3 bucket are visible to anyone, do you plan on adding a way to set credentials for the app to get the files ?

Yes, you are right: at the moment there is no way to set credentials in order for plugin to access secured files. This plugin feature is in plans. Thanks to @davidovich it was even implemented for iOS. I just need to find time to merge his PR and implement the same stuff for Android. At the moment I've been busy with fixing more critical issues.

Not relevant, but when running cordova-hcp init, why do you need the ios_identifier and android_identifier?

More details about this you can find in the plugins documentation: here and here. In short: you can use them to redirect user on the App Store/Google Play, so they would update the app. This was originally added in the plugin as the request from one of our developers, but not sure, that it is used in any way and should be in there.

nordnet-deprecation-bot commented 5 years ago

👋 Hi! Thank you for your interest in this repo.

đŸ˜ĸ We are not using nordnet/cordova-hot-code-push-cli anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹī¸ Please see #79 for more information.