search

nordnet / cordova-universal-links-plugin

[DEPRECATED] - Cordova plugin to support Universal/Deep Links for iOS/Android.
https://github.com/nordnet/cordova-universal-links-plugin/issues/160
MIT License
349 stars 530 forks source link

Made xcodePreferences.js compatible with Cordova v7 #114

Closed aramando closed 6 years ago

aramando commented 7 years ago

Fix for issue #110

TianleZhang commented 7 years ago

When can this ticket be merged to master?

jacquesdev commented 7 years ago

Yup, please merge this and release to npm :)

majid701 commented 7 years ago

@nikDemyankov please merge this pull request. It's needed can't run my ios app without it!

thanks

newuser44 commented 7 years ago

Did this get merged in? Not sure how to tell.

aramando commented 7 years ago

No, it hasn't been merged, I don't know why; it seems nobody is updating this plugin at the moment.

I would suggest just referencing this commit with the fix as your plugin source instead of the nordnet master. If you're uncomfortable relying on my repository you can always fork it and maintain your own source.

cordova plugin add --save https://github.com/aramando/cordova-universal-links-plugin#35b3ed7e9a0310b12f1ac92a5159b21ce50eee57

schmidt commented 6 years ago

I needed to add a .git to the Github URL, to make it work. Also --save seems to be the default now.

cordova plugin add https://github.com/aramando/cordova-universal-links-plugin.git#35b3ed7e9a0310b12f1ac92a5159b21ce50eee57

Other than that, I can confirm, that this change works as expected. Thanks for the help.

florgb02 commented 6 years ago

Is there any plans on merging this PR?

nordnet-deprecation-bot commented 6 years ago

👋 Hi! Thank you for your interest in this repo.

đŸ˜ĸ We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹī¸ Please see #160 for more information.