nordnet / cordova-universal-links-plugin

[DEPRECATED] - Cordova plugin to support Universal/Deep Links for iOS/Android.
https://github.com/nordnet/cordova-universal-links-plugin/issues/160
MIT License
349 stars 530 forks source link

Fix for issue #110 - support for Cordova 7.0 #122

Closed martindrapeau closed 6 years ago

ccorcos commented 7 years ago

@nikDemyankov can you take a look at this PR?

sam2x commented 7 years ago

Please merge this. The current code is breaking all cordova build project which want to use last cordova version. This patch is fixing it. Thanks for it @martindrapeau

ccorcos commented 7 years ago

@sam2x you can just pull this branch in the meantime:

    <plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />
ccorcos commented 7 years ago

@nikDemyankov whats taking so long?

ben-kn-app commented 7 years ago

Hi @ccorcos, I can't add your branch

<plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />

it gives the following error: fatal: reference is not a tree: 22225179a5debfcff801e306eb1bf5477200aeda

Any other way to add this branch?

ccorcos commented 7 years ago

sorry, wrong username:

<plugin name="cordova-universal-links-plugin" spec="https://github.com/martindrapeau/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />
ccorcos commented 7 years ago

Lets do this @nikDemyankov

mix3d commented 6 years ago

Is this commit better than PR #114?

musemind commented 6 years ago

This made me crazy working with Meteor, I had to change the file on every build when switching between branches. I forked the repo and made the changed of this pull request.

Feel free to use it cordova-universal-links-plugin-fix@1.2.1 (-fix suffix) for a quickfix. https://www.npmjs.com/package/cordova-universal-links-plugin-fix

nordnet-deprecation-bot commented 6 years ago

👋 Hi! Thank you for your interest in this repo.

đŸ˜ĸ We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹī¸ Please see #160 for more information.