Closed martindrapeau closed 6 years ago
Please merge this. The current code is breaking all cordova build project which want to use last cordova version. This patch is fixing it. Thanks for it @martindrapeau
@sam2x you can just pull this branch in the meantime:
<plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />
@nikDemyankov whats taking so long?
Hi @ccorcos, I can't add your branch
<plugin name="cordova-universal-links-plugin" spec="https://github.com/nordnet/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />
it gives the following error:
fatal: reference is not a tree: 22225179a5debfcff801e306eb1bf5477200aeda
Any other way to add this branch?
sorry, wrong username:
<plugin name="cordova-universal-links-plugin" spec="https://github.com/martindrapeau/cordova-universal-links-plugin#22225179a5debfcff801e306eb1bf5477200aeda" />
Lets do this @nikDemyankov
Is this commit better than PR #114?
This made me crazy working with Meteor, I had to change the file on every build when switching between branches. I forked the repo and made the changed of this pull request.
Feel free to use it cordova-universal-links-plugin-fix@1.2.1
(-fix suffix) for a quickfix.
https://www.npmjs.com/package/cordova-universal-links-plugin-fix
đ Hi! Thank you for your interest in this repo.
đĸ We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.
đ This will now be closed & locked.
âšī¸ Please see #160 for more information.
@nikDemyankov can you take a look at this PR?