nordnet / cordova-universal-links-plugin

[DEPRECATED] - Cordova plugin to support Universal/Deep Links for iOS/Android.
https://github.com/nordnet/cordova-universal-links-plugin/issues/160
MIT License
349 stars 529 forks source link

Move entitlements hook logic to plugin.xml #89

Closed alexbuijs closed 5 years ago

alexbuijs commented 7 years ago

In the upcoming cordova-ios 4.3.0 the entitlements can be configured through plugin.xml. See: https://issues.apache.org/jira/browse/CB-11854. This could be a replacement for the ios hooks for adding the entitlements.

nikDemyankov commented 7 years ago

Cool, thanks for the info! Although, I think entitlement hooks will remain for some time, since not everyone will upgrade to 4.3. I know some people, who are still using v3 for different reasons.

dorgold commented 7 years ago

This is not really an enhancement, this plugin is now broken in cordova-ios 4.3.0 and above.

Cordova now uses build.xcconfig to set: CODE_SIGN_ENTITLEMENTS = $(PROJECT_DIR)/$(PROJECT_NAME)/Entitlements-$(CONFIGURATION).plist

This overrides the entitlements file set by this plugin, and associated domains are not appearing in the new Entitlements-Debug.plist / Entitlements-Release.plist

chancezeus commented 7 years ago

For those in need, I did a "quick and dirty"/"it works for me" fix of the generation of the entitlements based on the newer cordova versions (Entitlements-[Debug/Release].plist). I do not currently have the time to make a more "code style" and/or backwards compatible fix but please see: chancezeus/cordova-universal-links-plugin@9e313aa63d13fbdc91c3a10d17f006f5367dcf90

mark-veenstra commented 6 years ago

https://github.com/Mediapioniers/cordova-universal-links-plugin/tree/refactor-hooks-for-cli-builds?files=1

nordnet-deprecation-bot commented 5 years ago

👋 Hi! Thank you for your interest in this repo.

đŸ˜ĸ We are not using nordnet/cordova-universal-links-plugin anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹī¸ Please see #160 for more information.