search

nordnet / cordova-universal-links-plugin

[DEPRECATED] - Cordova plugin to support Universal/Deep Links for iOS/Android.
https://github.com/nordnet/cordova-universal-links-plugin/issues/160
MIT License
349 stars 529 forks source link

Xcode 8 Warning on build for IOS #93

Closed jpduckwo closed 7 years ago

jpduckwo commented 7 years ago

The following warnings are now appearing when building with Xcode 8. Using plugin version 1.2.0.

...Plugins/cordova-universal-links-plugin/AppDelegate+CULPlugin.h:15:36: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)
...Plugins/cordova-universal-links-plugin/AppDelegate+CULPlugin.h:15:128: Block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)
divyachandraprakash commented 7 years ago

Inspite of these warnings, do universal links work for ios for you(whether you are able to listen to the incoming url?)

jpduckwo commented 7 years ago

Yes but the way they work in IOS is pretty average, e.g. safari only asks you if you want to open the link in the app, it doesn't automatically just open the app which is what I was expecting.

nikDemyankov commented 7 years ago

These warnings are not critical, but yeah - I should fix them. But they are not causing the behaviour you are experiencing.

Maybe there is some misconfiguration with apple-app-site-association file? Check this documentation, mainly - Creating and Uploading the Association File section. You can try to put it in https://<domain>/.well-known/apple-app-site-association.

nikDemyankov commented 7 years ago

Released v.1.2.1. Closing this one, since it's about warnings in build process. For other problems, please, create a separate issue.