search

nordnet / nordnet-ui-kit

Nordnet UI Kit
https://nordnet.github.io/nordnet-ui-kit/
106 stars 28 forks source link

Empty table headers #473

Closed wemstad closed 5 years ago

wemstad commented 5 years ago

Issue

In IE and Edge the header border on the tables does not render correctly if the <th> is empty. Expected: Expected Actual: Actual

Background

This is caused by a parent component having display: flex that Edge picks up and incorrectly applies it to thediv in the th. I have not been able to override this effect.

Fix

The fix in this PR injects a white space in any table cell that would otherwise be empty. Hence, render the table correctly.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.01%) to 83.318% when pulling f805567fbb84ff33ae8654228fe6c963ec5a6a43 on empty-table-headers into b50c348fb6db4ef064bd367e3bf4cdf074962236 on master.