fix: fix border bottom rendering on sticky headers in edge

nordnet / nordnet-ui-kit

Nordnet UI Kit

https://nordnet.github.io/nordnet-ui-kit/

106 stars 28 forks source link

fix: fix border bottom rendering on sticky headers in edge #504

Closed Unic0arn closed 5 years ago

Unic0arn commented 5 years ago

Second attempt at this. Only setting height 100% on Ths now to avoid breaking responsive rendering Switched to setting border on ::before to avoid it overlapping content when setting height 100% on that.

coveralls commented 5 years ago

Coverage decreased (-0.07%) to 83.695% when pulling b5040992f040f7c072ab77b47a6d31b126f860a6 on fix-th-bottom-border-for-real into 0036a2a835313e8c5253a8aeb4326463560f3fc0 on master.

JacobBlomgren commented 5 years ago

hm. can we verify this site wide in some way without risking creating and then reverting releases? I remember @bstream releasing under an -experimental flag

wemstad commented 5 years ago

I ran the whole site locally with this change and cant find any issues with it. Feels like a to small change to require a full experimental build.